Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PostProcessing: Fix OpenGL UBO linking with configuration options #9881

Merged
merged 1 commit into from Jul 14, 2021
Merged

PostProcessing: Fix OpenGL UBO linking with configuration options #9881

merged 1 commit into from Jul 14, 2021
+4 −1

Conversation

blaahaj
Copy link
Contributor

@blaahaj blaahaj commented Jul 9, 2021

No description provided.

@blaahaj blaahaj mentioned this pull request Jul 9, 2021
Closed
stenzek
stenzek approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@stenzek stenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Bad design that the loading is part of CreatePixelShader(), it should really be its own function.

@stenzek stenzek merged commit 9b17805 into dolphin-emu:master Jul 14, 2021
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stenzek stenzek stenzek approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@blaahaj @stenzek