VideoCommon: fix generic build #9887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On x86/ARM Common/Assert.h is included by way of
VideoCommon/VertexLoader{X64,ARM64}.h, on other platforms it is missing.
CrystalGamma
force-pushed
the
fix-vertexloader-generic
branch
from
5eb6989
to
beb6ec0
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
On x86/ARM
Common/Assert.his included by way ofVideoCommon/VertexLoader{X64,ARM64}.h, on other platforms it is missing.Commit is based on the breaking commit (daggy fix), not sure this is appreciated, considering Dolphin doesn't have maintenance branches to merge this into …
Contributing.mddoesn't say anything about it (and neither about commit naming). (Update: rebased onto master after advice on IRC)