JitArm64: Stop using hand-encoded logical immediates #9888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
force-pushed
the
jitarm64-logicalimm-everywhere
branch
2 times, most recently
from
b29e189
to
57001b9
Compare
degasus
reviewed
Jul 12, 2021
JosJuice
force-pushed
the
jitarm64-logicalimm-everywhere
branch
from
57001b9
to
6d6fd09
Compare
Setting bit 32 is only needed in the case where EQ and GT are set but SO and LT are not, which is not a possible outcome of a compare.
JosJuice
force-pushed
the
jitarm64-logicalimm-everywhere
branch
from
6d6fd09
to
3af21d3
Compare
degasus
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Follow-up to PR #9869.