make FPSCR.RN an enum #9907
Merged
make FPSCR.RN an enum #9907
+11
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a follow-up, SetRoundMode() and SetSIMDMode() can be merged since we don't care about x87 rounding anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This just addresses a comment I came across when grepping for
_MSC_VER.Compiles without warnings on msvc, unittests pass, and f-zero seems to run fine. The url in the comment is dead but I assume the issue was something relating to sign extension based on commit history and https://bugs.webkit.org/show_bug.cgi?id=134237
If this change isn't wanted anymore maybe we can just remove the comment instead?