Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MEM2 in the memory viewer in physical mode #9912

Merged
merged 1 commit into from Jul 21, 2021

Conversation

Pokechu22
Copy link
Contributor

Previously, looking at MEM2 in the physical mode (at 10000000) would show all zeros. However, the search feature would match the actual data. This happened because ReadU8 and WriteU8 did not account for the accessor's base offset (though search did). I'm somewhat surprised it didn't just crash in this case.

Note that effective mode (where MEM2 is at 90000000) worked properly before in most cases. The one exception I know of is with the FIFO player, where nothing seems to be mapped at 90000000; this is probably because fifologs don't store BATs. However, graphics-related logic all operates on physical addresses, so I'm not going to worry about that for now.

This change should have no impact on emulation, only on the memory viewer.

@Pokechu22
Copy link
Contributor Author

Correction: the previous behavior won't always result in seeing all zeros, but you still won't see actual contents of MEM2 (just whatever happens to be 0x10000000 (268,435,456) bytes after the start of MEM2 in the host system).

@leoetlino leoetlino merged commit 9a91b86 into dolphin-emu:master Jul 21, 2021
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants