Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameINI: Improve Rendering in Sin & Punishment: Star Successor #9925

Merged
merged 1 commit into from Jul 21, 2021

Conversation

JMC47
Copy link
Contributor

@JMC47 JMC47 commented Jul 20, 2021

Sin & Punishment: Star Successor has rendering issues in the upper left part of the screen. While we can't completely fix it, by disabling Store EFB Copies to Texture only, we can make it from a missing box to just a couple of lines being incorrectly visible that make up the copy region's borders.

This makes the game much more playable in the meantime.

@JosJuice
Copy link
Member

Preferably put a comment about this in the INI itself, in case the issue gets improved on in the future. (Actually, maybe putting comments in the INI is something that would be useful in other cases too...?)

@JMC47
Copy link
Contributor Author

JMC47 commented Jul 20, 2021

The copy region issue will probably not get fixed. The lines around it might. That's why I didn't put a comment in the INI.

@JMC47
Copy link
Contributor Author

JMC47 commented Jul 20, 2021

Updated with a comment about the copy region.

# Store EFB Copies to Texture Only must be disabled to prevent
# the copy region from showing the incorrect graphics.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Store EFB Copies to Texture Only must be disabled to prevent
# the copy region from showing the incorrect graphics.
# Store EFB Copies to Texture Only must be disabled to prevent
# the copy region from showing incorrect graphics.

@Rumi-Larry
Copy link

Also there are two extra empty lines at the very bottom.

Sin & Punishment: Star Successor has rendering issues in the upper left
part of the screen.  While we can't completely fix it, by disabling
Store EFB Copies to Texture only, we can make it from a missing box to
just a couple of lines being visible that make up the copy region.
@leoetlino leoetlino merged commit bf36baa into dolphin-emu:master Jul 21, 2021
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants