DSPHLE: re-enable low-pass filter #9929
Merged
+1
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe this got fixed? Sonic Colors probably needs it for underwater audio.
|
This probably doesn't need to be a draft. I took some time to test a couple dozen games this morning between the different microcode revisions and it seems fine. Fixes a ton of minor audio errors, from Paper Mario to Sonic Colors. |
|
The comment mentions Super Monkey Ball, did you check that game? If theres nothing of note, I'd also opt to just re-enable it. Plus, if something still is wrong with it, broken audio is more noticable than no audio. |
|
Super Monkey Ball is not broken. I'd prefer to merge this sooner than later so that we have time to catch any regressions before the next beta. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Sonic Colors probably needs this for underwater audio: https://bugs.dolphin-emu.org/issues/10069
No idea whether it's still broken or not.