GetOpInfo: Assert on all invalid Ops. #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetOpInfo was returning null pointers for invalid ops in subtables instead of asserting an error. This was causing segfaults when the jit tried to jit invalid code.
|
This looks good to me. |
|
LGTM |
skidau
added a commit
that referenced
this pull request
Sep 6, 2014
GetOpInfo: Assert on all invalid Ops.
|
This looks bad to me. Now it crashes whenever I try to start Metroid Prime 2 (info is null). |
|
I can also confirm that I am crashing in Kirby Air Ride, Paper Mario: TTYD, and likely several other titles as well as of this PR. |
|
Crashes both Burnout and Burnout 2: Point of Impact. Anyone found any unaffected games? |
|
VC titles seem to be unaffected, but I'm crashing in every GCN/Wii title that I've tried so far. |
comex
added a commit
that referenced
this pull request
Sep 6, 2014
Revert "Merge pull request #993 from phire/fix_getOpInfo"
Funny that, I only tested on VC games. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
GetOpInfo was returning null pointers for invalid ops in subtables instead of asserting an error. This was causing segfaults when the jit tried to jit invalid code.