msbuild: reduce number of cl batches for mgba #9931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoetlino
reviewed
Jul 21, 2021
| <ClCompile Include="mgba\src\gb\cheats.c"> | ||
| <ObjectFileName>$(IntDir)/src/gb/cheats.c.obj</ObjectFileName> | ||
| <ObjectFileName>$(IntDir)obj2\</ObjectFileName> |
There was a problem hiding this comment.
Could we call those gb and gba rather than objX?
There was a problem hiding this comment.
I decided not to because the (object) files aren't actually split up that way (because there are sometimes duplicate names outside of gb/gba dirs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
minor build perf improvement