Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StringUtil: Remove unused function BuildCompleteFilename #9933

Conversation

Dentomologist
Copy link
Contributor

Aside from being unused it has a strange interface and implementation.

It's barely been touched since the initial git megacommit; I'm guessing it was meant to work around missing Return Value Optimization in ancient compilers?

@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

automated-fifoci-reporter

@JosJuice JosJuice merged commit 484279f into dolphin-emu:master Jul 22, 2021
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants