GBA: Add "Scan e-Reader Card(s)" context menu item #9938
Conversation
|
I guess I'll have to test this lol |
| @@ -281,6 +298,10 @@ void GBAWidget::contextMenuEvent(QContextMenuEvent* event) | |||
| unload_action->setEnabled(CanControlCore() && !m_game_title.empty()); | |||
| connect(unload_action, &QAction::triggered, this, &GBAWidget::UnloadROM); | |||
|
|
|||
| auto* card_action = new QAction(tr("&Load e-Reader Card"), menu); | |||
| card_action->setEnabled(CanControlCore() && !m_game_title.empty()); | |||
There was a problem hiding this comment.
| card_action->setEnabled(CanControlCore() && !m_game_title.empty()); | |
| card_action->setEnabled(CanControlCore()); |
There was a problem hiding this comment.
Don't you need to load the e-Reader ROM first? Or does that happen automatically?
There was a problem hiding this comment.
e-Reader itself has to be loaded in order to scan cards. It's like a normal game in how it is loaded in mGBA.
There was a problem hiding this comment.
Alright, then I think it makes sense to still require a non-empty game title if you can't load a card when the e-Reader itself is loaded. (It'd be better to check if it's the e-Reader itself that's loaded, but I'm not sure how to do that.)
Source/Core/DolphinQt/GBAWidget.cpp
Outdated
| @@ -281,6 +298,10 @@ void GBAWidget::contextMenuEvent(QContextMenuEvent* event) | |||
| unload_action->setEnabled(CanControlCore() && !m_game_title.empty()); | |||
| connect(unload_action, &QAction::triggered, this, &GBAWidget::UnloadROM); | |||
|
|
|||
| auto* card_action = new QAction(tr("&Load e-Reader Card"), menu); | |||
There was a problem hiding this comment.
Thoughts on changing this to &Scan e-Reader Card?
There was a problem hiding this comment.
Hard agree. Because most e-Reader cards are in pairs, you have to scan two at once. So you scan one, hit a button, scan another.
There was a problem hiding this comment.
I've implemented loading multiple cards at once. Would it make sense to change it to &Scan e-Reader Card(s), or is just &Scan e-Reader Card fine?
Pokechu22
force-pushed
the
e-reader-context-menu-item
branch
from
7ec3e89
to
7e6fd43
Compare
|
Should the Pull Request's name be changed then? |
Pokechu22
force-pushed
the
e-reader-context-menu-item
branch
from
7e6fd43
to
50109d7
Compare
Pokechu22
changed the title
See issue 12588. This doesn't introduce any more complicated functionality; it only exposes the functionality that was already available via drag and drop in a more discoverable way.
I haven't tested this at all.