Readme: Copy the submodule note to non-Windows sections #9939
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulling submodules is necessary now that mGBA is integrated. Perhaps having the same submodule note repeated three times in the different sections of the readme file is a bit odd, but I don't know of a fitting section to put it in that isn't OS-specific...
|
Hm, pulling all submodules will result in the Windows Qt submodule getting pulled, even though it's pointless on systems other that Windows... Should we recommend something other than pulling all submodules? |
|
If it wasn't for Windows, I'd suggest writing a shell script that checks the system and excludes Qt if not needed (or maybe even have CMake do it). |
|
eh, I don't think it's worth the trouble when our non-Windows buildbots also just pull all submodules |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Pulling submodules is necessary now that mGBA is integrated.
Perhaps having the same submodule note repeated three times in the different sections of the readme file is a bit odd, but I don't know of a fitting section to put it in that isn't OS-specific...