AudioPane: Adjust DSP selection names #9941
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miksel12
reviewed
Jul 23, 2021
| m_dsp_lle = new QRadioButton(tr("DSP LLE Recompiler")); | ||
| m_dsp_interpreter = new QRadioButton(tr("DSP LLE Interpreter (slow)")); | ||
| m_dsp_hle = new QRadioButton(tr("DSP HLE (recommended)")); | ||
| m_dsp_lle = new QRadioButton(tr("DSP LLE Recompiler(slow)")); |
There was a problem hiding this comment.
Suggested change
| m_dsp_lle = new QRadioButton(tr("DSP LLE Recompiler(slow)")); | |
| m_dsp_lle = new QRadioButton(tr("DSP LLE Recompiler (slow)")); |
To keep formatting the same.
JMC47
force-pushed
the
dsprecommendations
branch
from
f074301
to
a03092e
Compare
JMC47
force-pushed
the
dsprecommendations
branch
from
a03092e
to
59e6048
Compare
lioncash
approved these changes
Jul 23, 2021
|
For the sake of translations, it would be preferable to not change important strings like these when we're close to tagging a beta release. I'll see if I can do another Transifex sync to hopefully get this translated in time, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I've seen a lot of users selecting DSP-LLE because they figure "how slow can audio emulation be?" and not really realizing that DSP-LLE is the reason that their game is lagging. I don't know if this is the right thing to do, but I feel like our DSP emulation is good enough that every game that needs DSP-LLE to function has it enabled by default.
Anyway, I think to help reduce user confusion it might be good to explicitly mark DSP-HLE as recommended, and mark DSP-LLE Recompiler as slow. DSP-LLE Interpreter I've marked as very slow as it is very slow.