Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MemoryViewWidget: Remove unnecessary column #9942

Merged
merged 1 commit into from Jul 23, 2021

Conversation

Pokechu22
Copy link
Contributor

This column would end up containing junk data after changing the data type, specifically whatever data was already in that column in the previous datatype.

Column 0 is used for a breakpoint indicator (if the entire row has breakpoints). Column 1 is the address. Columns 2 through 2+n, exclusive, are used for the data for the row, where n varies by data type (for U8 it's 16, but for float and U32 it's 4); for example, with float, columns 2, 3, 4, and 5 are in use. Thus, there are 6 columns (0 through 5), which is 2+4, not 3+4.

Before: First set to U8, then change to float
After: First set to U8, then change to float

This column would end up containing junk data after changing the data type.
@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

  • jj-awae-mirrored on uberogl-lin-radeon: diff

automated-fifoci-reporter

@lioncash lioncash merged commit 6229aa1 into dolphin-emu:master Jul 23, 2021
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants