Android: Allow non-square overlay control images

[JosJuice]

This removes an assumption in the code which made every overlay control image be scaled to a square even if the actual image was rectangular.

[dolphin-emu-bot]

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

• soniccolors-mm on uberogl-lin-radeon: diff

_{^{automated-fifoci-reporter}}

[blakbin]

im tested it but it seem no change. the classic L & R button still has Rectangle Bound, in my phone width and height still 259x259

[JosJuice]

That's because I didn't change any of the image files. I was thinking that could be done in a separate PR if desired.

[blakbin]

im using crop before scaled, everything looked fine and now if any button gotten hit on transparent area it will be not get pressed state, but my code look like dirty

public static Bitmap resizeBitmap(Context context, Bitmap bitmap, float scale)
  {
    // Determine the button size based on the smaller screen dimension.
    // This makes sure the buttons are the same size in both portrait and landscape.
    DisplayMetrics dm = context.getResources().getDisplayMetrics();
    int minScreenDimension = Math.min(dm.widthPixels, dm.heightPixels);

    int minX = bitmap.getWidth();
    int minY = bitmap.getHeight();
    int maxX = -1;
    int maxY = -1;
    for(int y = 0; y < bitmap.getHeight(); y++)
    {
      for(int x = 0; x < bitmap.getWidth(); x++)
      {
        int alpha = (bitmap.getPixel(x, y) >> 24) & 255;
        if(alpha > 0) 
        {
          if(x < minX)
            minX = x;
          if(x > maxX)
            maxX = x;
          if(y < minY)
            minY = y;
          if(y > maxY)
            maxY = y;
        }
      }
    }
    Bitmap croppedBitmap = Bitmap.createBitmap(bitmap, minX, minY, (maxX - minX) + 1, (maxY - minY) + 1);

    int maxBitmapDimension = Math.max(croppedBitmap.getWidth(), croppedBitmap.getHeight());
    float bitmapScale = scale * minScreenDimension / maxBitmapDimension;

    return Bitmap.createScaledBitmap(croppedBitmap,
      (int) (croppedBitmap.getWidth() * bitmapScale),
      (int) (croppedBitmap.getHeight() * bitmapScale),
      true);
  }

[ghost]

Any news about this?

[JosJuice]

As far as I'm concerned, this is ready to go.

[t895]

I don't have a good way of testing rectangular images at the moment but LGTM