Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSPHLE: fix and re-enable polyphase resampling #9955

Merged
merged 1 commit into from Jul 25, 2021
Merged

DSPHLE: fix and re-enable polyphase resampling #9955

merged 1 commit into from Jul 25, 2021

Conversation

Tilka
Copy link
Member

@Tilka Tilka commented Jul 25, 2021

This fixes the title screen music of Snowpack Park (https://bugs.dolphin-emu.org/issues/12499).

@Tilka Tilka requested a review from delroth July 25, 2021 03:49
JMC47
JMC47 requested changes Jul 25, 2021
View reviewed changes
Copy link
Contributor

@JMC47 JMC47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work with savestates, currently.

@JMC47
Copy link
Contributor

JMC47 commented Jul 25, 2021

This fixes the HLE audio issues in Snowpack Park and the two Pokemon games.

@Tilka
DSPHLE: fix and re-enable polyphase resampling
14da138 
This fixes the title screen music of Snowpack Park.
JMC47
JMC47 approved these changes Jul 25, 2021
View reviewed changes
Copy link
Contributor

@JMC47 JMC47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Savestate issue as a pre-existing condition.

@Tilka Tilka merged commit 1119488 into dolphin-emu:master Jul 25, 2021
11 checks passed
@Tilka Tilka deleted the ax2 branch July 25, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sepalani sepalani sepalani left review comments

@JMC47 JMC47 JMC47 approved these changes

@delroth delroth

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@Tilka @JMC47 @sepalani