Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt: GBA QoL improvements #9959

Merged
merged 5 commits into from Jul 25, 2021
Merged

Qt: GBA QoL improvements #9959

merged 5 commits into from Jul 25, 2021

Conversation

Bonta0
Copy link
Contributor

@Bonta0 Bonta0 commented Jul 25, 2021

This adds features frequently requested by users to the GBA windows

@JMC47
Copy link
Contributor

JMC47 commented Jul 25, 2021

@dolphin-emu-bot rebuild

Copy link
Contributor

@JMC47 JMC47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is tested to work. Tested Animal Crossing and Nintendo Puzzle Collection for Interframe blending. Tested fullscreen shenanigans for the always on top and borderless GBA.

@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

  • soniccolors-mm on uberogl-lin-radeon: diff

automated-fifoci-reporter

@Tilka Tilka merged commit 3e04cb6 into dolphin-emu:master Jul 25, 2021
11 checks passed
@WeedyWeedSmoker
Copy link

WeedyWeedSmoker commented Oct 3, 2021

This commit breaks compatibility with macOS 10.13 (still works on the newer macOS 11 version, didn't test other macOSes…)

@Bonta0, @JMC47

@JMC47
Copy link
Contributor

JMC47 commented Oct 3, 2021

I can update the FAQ to change the minimum requirements.

@JosJuice
Copy link
Member

JosJuice commented Oct 3, 2021

But I can't see anything in this PR that would cause macOS 10.13 to break... I don't think you should update the minimum requirements until the reason why it broke is understood.

@WeedyWeedSmoker
Copy link

WeedyWeedSmoker commented Oct 3, 2021

@JMC47 @JosJuice Let me test again, this specific commit now seems to work fine on 10.13, I'm checking which commit actually broke it, this commit is indeed important!

Edit : It seems to be the commit right after this one which crashes macOS 10.13 with a Segfault…

@JMC47
Copy link
Contributor

JMC47 commented Oct 3, 2021

I just meant that as a nuclear option, we can raise the minimum requirements. Obviously if it's something silly or unintended, we can try to fix it.

@WeedyWeedSmoker
Copy link

@JMC47 @JosJuice 5.0-14748 crashes, while 5.0-14746 works fine… The culprit is between this commit (3e04cb6) and 7fe97b2, I will try to compile those in-between commits to try and find the real culprit, while 46e331d seems to be a good candidate for a crash on macOS 10.13 somehow…

@WeedyWeedSmoker
Copy link

WeedyWeedSmoker commented Oct 4, 2021

@JMC47 @JosJuice I can't manage to compile Dolphin on macOS, finally got my Qt5 detected, but then got errors with <optional>, trying this : https://github.com/youknowone/xcode-libcxx but brew got certificate errors trying to download a required part of llvm…

Do you have a way to compile the aforementioned commits for mac ?

(namely 46e331d, 9a33fd3 (certainly not related) and c9a4021 …)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants