Jit64: Fix fmaddXX with accurate NaNs #9970
Merged
+49
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it turns out you have to pass XMM0 as the clobber register to HandleNaNs, because HandleNaNs uses BLENDVPD and BLENDVPD implicitly uses XMM0, and nobody noticed when I broke this in 2c38d64 because nobody plays the one game that needs accurate NaNs.
JosJuice
force-pushed
the
jit64-fmaddxx-accurate-nan
branch
from
88f7698
to
3bb4a4e
Compare
|
Which game needs this behavior? Could that be put into the commit message and/or as a comment? |
|
It is Dragon Ball: Revenge of King Piccolo. This is mentioned in a comment in the implementation of |
|
This fixes accurate NaNs when enabled. |
lioncash
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
So it turns out you have to pass
XMM0as the clobber register toHandleNaNs, becauseHandleNaNsusesBLENDVPDandBLENDVPDimplicitly usesXMM0, and nobody noticed when I broke this in 2c38d64 because nobody plays the one game that needs accurate NaNs.