Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recompile shaders when 'Enable API Validation Layers' is toggled #9972

Merged
merged 4 commits into from Jul 31, 2021
Merged

Recompile shaders when 'Enable API Validation Layers' is toggled #9972

merged 4 commits into from Jul 31, 2021
+43 −51

Conversation

Pokechu22
Copy link
Contributor

This causes shaders to be reloaded when 'Enable API Validation Layers' is toggled. It also does some general fixing and cleanup of related code.

@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

automated-fifoci-reporter

iwubcode
iwubcode approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@iwubcode iwubcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise LGTM. Untested.

@Tilka Tilka merged commit 0470be5 into dolphin-emu:master Jul 31, 2021
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwubcode iwubcode iwubcode approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@Pokechu22 @dolphin-emu-bot @iwubcode @Tilka