Jit: Use accurate negation order for FMA instructions #9973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes issue https://bugs.dolphin-emu.org/issues/12297 |
|
Performance doesn't seem to be any different from what I can tell. |
booto
reviewed
Jul 29, 2021
| MOVAPD(XMM1, R(result_xmm)); | ||
| result_xmm = XMM1; | ||
| MOVAPD(Rd, R(result_xmm)); | ||
| result_xmm = Rd; |
There was a problem hiding this comment.
Feel free to ignore, but I think you can lift the two HandleNaNs() below to here as well
It was believed that this only mattered when the rounding mode was set to round to infinity, which games generally don't do, but it can also affect the sign of the output when the inputs are all zero.
JosJuice
force-pushed
the
jit-fma-negation-order
branch
from
2079beb
to
08b358a
Compare
booto
approved these changes
Jul 29, 2021
lioncash
approved these changes
Aug 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was believed that this only mattered when the rounding mode was set to round to infinity, which games generally don't do, but it can also affect the sign of the output when the inputs are all zero.