JitArm64: Implement mtfsfx #9977
Merged
+58
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
lioncash
approved these changes
Jul 31, 2021
lioncash
reviewed
Jul 31, 2021
| for (int i = 0; i < 8; i++) | ||
| { | ||
| if (inst.FM & (1 << i)) | ||
| mask |= 0xF << (4 * i); |
There was a problem hiding this comment.
Suggested change
| mask |= 0xF << (4 * i); | |
| mask |= 0xFU << (4 * i); |
Otherwise this is ORing a signed value
The sixth and final part of implementing the FPSCR system register instructions.
JosJuice
force-pushed
the
jitarm64-mtfsfx
branch
from
d67823b
to
a90b0a1
Compare
lioncash
approved these changes
Jul 31, 2021
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The sixth and final part of implementing the FPSCR system register instructions.