Jit: Use ibat_table for dcbf/dcbi/dcbst address check #9978
+11
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor mistake in 92d1d60. We should be using ibat_table instead of dbat_table, since we're dealing with invalidating icache.
degasus
reviewed
Aug 1, 2021
| @@ -91,9 +91,9 @@ void EmuCodeBlock::SwitchToNearCode() | |||
| SetCodePtr(m_near_code, m_near_code_end, m_near_code_write_failed); | |||
| } | |||
|
|
|||
| FixupBranch EmuCodeBlock::BATAddressLookup(X64Reg addr, X64Reg tmp) | |||
| FixupBranch EmuCodeBlock::BATAddressLookup(X64Reg addr, X64Reg tmp, const void* bat_table) | |||
There was a problem hiding this comment.
I'd prefer const uint64_t* bat_table, but I don't care much.
There was a problem hiding this comment.
It would have to be uint32_t instead of uint64_t in order to not make calling this function awkward, since the BAT table type is defined as using BatTable = std::array<u32, 1 << (32 - BAT_INDEX_SHIFT)>.
Originally I was going to pass in const BatTable&, but then I realized I would need to include MMU.h in EmuCodeBlock.h (doing a simple class BatTable; forward declaration isn't possible with using), so I switched to this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Minor mistake in PR #9957. We should be using ibat_table instead of dbat_table, since we're dealing with invalidating icache.