Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jit64: Always pass effective address to InvalidateICache() in dcbx. #9995

Merged
merged 2 commits into from
Aug 4, 2021
Merged

Jit64: Always pass effective address to InvalidateICache() in dcbx. #9995

merged 2 commits into from
Aug 4, 2021

Conversation

AdmiralCurtiss
Copy link
Contributor

Note: Includes #9991.

@JosJuice
Jit64: Fix BATAddressLookup bit test
5bd188d 
BT sets the carry flag, not the zero flag.
@JMC47
Copy link
Contributor

JMC47 commented Aug 4, 2021

Fixes https://bugs.dolphin-emu.org/issues/12608

JosJuice
JosJuice approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@JosJuice JosJuice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm more used to calling it effective address than virtual address (in a PowerPC context). But you can ignore that if you want to.

LGTM other than that.

@AdmiralCurtiss AdmiralCurtiss changed the title Jit64: Always pass virtual address to InvalidateICache() in dcbx. Jit64: Always pass effective address to InvalidateICache() in dcbx. Aug 4, 2021
@leoetlino leoetlino changed the title Jit64: Always pass effective address to InvalidateICache() in dcbx. Jit64: Always pass effective address to InvalidateICache() in dcbx. Aug 4, 2021
@leoetlino leoetlino merged commit 28b7e2e into dolphin-emu:master Aug 4, 2021
@dolphin-emu-bot
Copy link
Contributor

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

  • hb-discgolf on uberogl-lin-radeon: diff

automated-fifoci-reporter

@AdmiralCurtiss AdmiralCurtiss deleted the dcbx-virtual-address branch August 4, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoetlino leoetlino leoetlino approved these changes

@JosJuice JosJuice JosJuice approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AdmiralCurtiss @JMC47 @dolphin-emu-bot @leoetlino @JosJuice