Jit: Re-add dcbx masking #9999
Merged
Jit: Re-add dcbx masking #9999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When making 92d1d60, I checked whether the ~0x1f masking in dcbx actually was necessary. I came to the conclusion that it wasn't, so I removed it. However, I hadn't checked the second half of InvalidateICache closely enough - the masking is actually needed. This commit re-adds the masking, but this time in C++ code instead of in jitted code in order to save icache. Though I suppose the difference doesn't matter all that much, since this is in farcode and all... Hopefully fixes https://bugs.dolphin-emu.org/issues/12612.
JosJuice
force-pushed
the
jit-dcbx-masking
branch
from
71daca7
to
125af42
Compare
|
Yes, this fixes TP under MMU. |
AdmiralCurtiss
approved these changes
Aug 6, 2021
lioncash
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When making PR #9957, I checked whether the ~0x1f masking in dcbx actually was necessary. I came to the conclusion that it wasn't, so I removed it. However, I hadn't checked the second half of InvalidateICache closely enough – the masking is actually needed.
This commit re-adds the masking, but this time in C++ code instead of in jitted code in order to save icache. Though I suppose the difference doesn't matter all that much, since this is in farcode and all...
Hopefully fixes https://bugs.dolphin-emu.org/issues/12612 (not tested).