Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dolt SQL shell backspace weirdness #141

Closed
timsehn opened this issue Oct 15, 2019 · 3 comments
Closed

Dolt SQL shell backspace weirdness #141

timsehn opened this issue Oct 15, 2019 · 3 comments
Labels
bug Something isn't working
Projects

Comments

@timsehn
Copy link
Sponsor Contributor

timsehn commented Oct 15, 2019

Repro:

  1. Make a sql query that spans more than one line
  2. Execute the query
  3. Hit up to go back to the query
  4. Backspace over the line break
  5. It starts to eat the results above and not actually backspace
@timsehn timsehn added the bug Something isn't working label Oct 15, 2019
@oscarbatori
Copy link
Contributor

oscarbatori commented Dec 27, 2019

@zachmu are we intending to do anything about this? Fine if you don't think it's worth it, but just want to set the appropriate status.

@oscarbatori oscarbatori added this to Backlog in Dolt Dec 27, 2019
@zachmu
Copy link
Member

zachmu commented Dec 27, 2019

Yes, we need to fix this. It's a bug in the readline library we're using. Fix is to replace the readline library to one that doesn't have the bug, but that means rewriting large parts of our shell. There's a TODO in the code for this as well.

cockroachdb/cockroach#15460

@zachmu
Copy link
Member

zachmu commented Aug 6, 2021

The dolt SQL shell still could use some work, but this bug is no longer relevant (we remove newlines from queries before putting them in the query history)

@zachmu zachmu closed this as completed Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Dolt
  
Backlog
Development

No branches or pull requests

3 participants