2.1.5

Merged PRs

dolt

• 11185: go/store/nbs: boostrapJournal: Improve journal bootstraping resiliency in the face of errors in journal.idx.
  journal.idx is an optimization to make opening the database faster. Errors in reading it should never cause opening the database to fail. Make it so that we gracefully handle data and I/O errors in accessing journal.idx so that database opening proceeds as expected.
  There is still one fatal error associated with journal.idx: when we are in read-write mode, we must be able to open journal.idx for writing.
• 11184: bug fix for merging tables with vector indexes
  Fixes: #11180
  Related Doltgres update to skip the unsupported VECTOR index test: dolthub/doltgresql#2827

go-mysql-server

• 3578: fix: retain table comment when primary key is a separate clause
  CREATE TABLE ... COMMENT='c' dropped the comment when PRIMARY KEY was given as a separate clause.
  • Add a comment parameter to IndexedTableCreator.CreateIndexedTable and thread it through the executor.
    Block #11170
• 3572: Rewrite CachedResults node and cachedResultsIter to not use MemoryManager
  This PR is a follow-up to #3561 and further addresses the memory leak mentioned in #3560. While the initial fix in #3561 made it seem like the issue was that we were not properly disposing of the CachedResults node, the real issue was that a cachedResultsIter that never wrote to the CachedResults node was never disposed of in the MemoryManager if it was never closed.
  This PR rewrites the CachedResults node and cachedResultsIter to never actually make use of the MemoryManager. Since we do not make use of parallel partitions, there's no need to have a locking cache. Instead, the results of the cachedResultsIter are stored directly in the CachedResults node. This greatly simplifies both the CachedResults node and the cachedResultsIter.
  This PR also moves the emptyCacheIter and EmptyIter out of the plan package and de-dupes any code related to empty iters.

Closed Issues

• 11180: 3-way DOLT_MERGE fails on table with VECTOR INDEX: expected prollyIndex, found: durable.proximityIndex