Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a number of bugs in aliases and name resolution revealed by recent changes to the parser #350

Merged
merged 9 commits into from Mar 31, 2021
Merged

Fixed a number of bugs in aliases and name resolution revealed by recent changes to the parser #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cc7ef6c
Improved alias resolution in resolve_columns
zachmu Mar 30, 2021
434b4fb
Fixed bug in indexing columns of ModifyColumn nodes
zachmu Mar 30, 2021
1c01785
Fixed bug in pushdown_groupby_aliases
zachmu Mar 30, 2021
b4f1ba4
Incomplete solution to order by literal bug
zachmu Mar 30, 2021
bd4080d
Fixed bug with ambiguous column names in orderby clause
zachmu Mar 30, 2021
bfa42a0
Additional tests, including one broken one
zachmu Mar 30, 2021
6c1772c
Added output schema verification to engine tests, wrote some more tes…
zachmu Mar 30, 2021
924604c
Formatting
zachmu Mar 30, 2021
7cd80cd
Merge master
zachmu Mar 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions enginetest/engine_test.go
View file
Open in desktop
Expand Up @@ -87,7 +87,7 @@ func TestDescribe(t *testing.T) {
for _, q := range queries {
enginetest.TestQuery(t, harness, e, q, []sql.Row{
sql.NewRow("Table(mytable)"),
}, nil)
}, nil, nil)
}
})

Expand All @@ -98,7 +98,7 @@ func TestDescribe(t *testing.T) {
enginetest.TestQuery(t, parallelHarness, ep, q, []sql.Row{
{"Exchange(parallelism=2)"},
{" └─ Table(mytable)"},
}, nil)
}, nil, nil)
}
})
}
Expand Down