Fix for #41 - proxy support #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dom96
requested changes
Jan 10, 2018
| let auth = | ||
| if parsed.username.len > 0: parsed.username & ":" & parsed.password | ||
| else: "" | ||
| return newProxy($parsed, auth) |
There was a problem hiding this comment.
I find this code odd. Doesn't httpclient provide this logic? If not, I think it should. But we can take care of that later.
There was a problem hiding this comment.
Nope, this isn't in httpclient.nim yet. I know you mentioned this separately as well but I added this to choosenim for the near term.
|
This will do for now but I would like it in the stdlib. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sourced getProxy() from Nimble