IRCv3 tags parsed into a StringTable #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add tests? |
|
Seeing as the current parser doesn't have tests I'm willing to merge this. If someone has the time it would be nice to see some tests for this via another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a little change to allow for simple handling of IRCv3 tags, obviously most of the library isn't totally up to IRCv3 spec but this lets people manually CAP REQ for tags and then recieve them without breaking some of the parsing, which is what was happening before - for messages without these tags, or if you just want to ignore tags entirely the library still works as before, just now with an event.tags string table