New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on V8 ToT #1

Open
TimothyGu opened this Issue Sep 11, 2017 · 7 comments

Comments

Projects
None yet
4 participants
@TimothyGu

TimothyGu commented Sep 11, 2017

V8 Release 6.2

We’ve also significantly improved the performance of ES2015 proxies, ... the performance of accessing a property on a proxy object via someProxy.property improved by almost 6.5×

@domenic

This comment has been minimized.

Show comment
Hide comment
@domenic

domenic Sep 12, 2017

Owner

This is mainly blocked by getting a single-file bundle that can run in d8 or Canary. You can see some attempts in this repo but they're blocked on grammarkdown reading grammar files using fs.

Owner

domenic commented Sep 12, 2017

This is mainly blocked by getting a single-file bundle that can run in d8 or Canary. You can see some attempts in this repo but they're blocked on grammarkdown reading grammar files using fs.

@TimothyGu

This comment has been minimized.

Show comment
Hide comment
@TimothyGu

TimothyGu Sep 12, 2017

There are Node.js builds running on latest V8 at https://nodejs.org/download/v8-canary/. A rough test shows execution going from 17 seconds to 15 seconds, though that might just be general improvements rather than Proxy specifically.

TimothyGu commented Sep 12, 2017

There are Node.js builds running on latest V8 at https://nodejs.org/download/v8-canary/. A rough test shows execution going from 17 seconds to 15 seconds, though that might just be general improvements rather than Proxy specifically.

@TimothyGu

This comment has been minimized.

Show comment
Hide comment
@TimothyGu

TimothyGu Sep 13, 2017

A more comprehensive test.

So whereas converting NamedNodeMap to Proxy increased processing time by 1.9 seconds on V8 6.0, on V8 6.3 that number is 0.5 seconds. That looks pretty good to me.

TimothyGu commented Sep 13, 2017

A more comprehensive test.

So whereas converting NamedNodeMap to Proxy increased processing time by 1.9 seconds on V8 6.0, on V8 6.3 that number is 0.5 seconds. That looks pretty good to me.

@bmeurer

This comment has been minimized.

Show comment
Hide comment
@bmeurer

bmeurer Sep 13, 2017

Collaborator

Kudos to @MayaLekova 👍

Collaborator

bmeurer commented Sep 13, 2017

Kudos to @MayaLekova 👍

@MayaLekova

This comment has been minimized.

Show comment
Hide comment
@MayaLekova

MayaLekova Sep 13, 2017

Collaborator

Happy to hear that and thank you for the results!

Collaborator

MayaLekova commented Sep 13, 2017

Happy to hear that and thank you for the results!

@domenic

This comment has been minimized.

Show comment
Hide comment
@domenic

domenic Sep 21, 2017

Owner

@TimothyGu in jsdom/jsdom#1934 you said that porting NamedNodeMap to use Proxy causes compilation time to go from 18s to 2min. That doesn't seem to reflect the above; what happened?

Owner

domenic commented Sep 21, 2017

@TimothyGu in jsdom/jsdom#1934 you said that porting NamedNodeMap to use Proxy causes compilation time to go from 18s to 2min. That doesn't seem to reflect the above; what happened?

@TimothyGu

This comment has been minimized.

Show comment
Hide comment
@TimothyGu

TimothyGu Sep 21, 2017

@domenic I'm honestly not sure. Might be a glitch during testing...

TimothyGu commented Sep 21, 2017

@domenic I'm honestly not sure. Might be a glitch during testing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment