Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for getting commits of line range #61

Merged
merged 1 commit into from Oct 2, 2020

Conversation

@SalmonMode
Copy link
Contributor

@SalmonMode SalmonMode commented Oct 1, 2020

Closes #60

I had to tweak a variable name because TS was complaining. Also several tests are failing, but I don't think it's because of what I did.

@SalmonMode SalmonMode changed the title Add support for getting commits of line range [WIP] Add support for getting commits of line range Oct 1, 2020
@hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Oct 1, 2020

Could you rebase? I reverted the PR that broke all the tests

Loading

@SalmonMode
Copy link
Contributor Author

@SalmonMode SalmonMode commented Oct 2, 2020

@hipstersmoothie Thanks! I rebased, added a test, and also modified a few of the tests a little bit just to speed the tests up a little (they were all calling gitlog the same way, and none modify the results, so it's safe).

Loading

@hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Oct 2, 2020

Awesome! Running the tests locally though it looks like one of them doesn't pass

 ✕ returns C100 status for files that are copied (1535ms)

Loading

@SalmonMode
Copy link
Contributor Author

@SalmonMode SalmonMode commented Oct 2, 2020

hmmmm it's passing for me. I also ran the create repo script and ran the commands myself, and it seems to be working.

The command it came up with for that one was this for me:

git log --find-copies-harder -n 10 --pretty="@begin@        %h      %H      %s      %an     %ai@end@" --name-status

I also confirmed with a similar test (returns A status for files that are added), which produces this command

git log -n 10 --pretty="@begin@     %h      %H      %s      %an     %ai@end@" --name-status

and when I ran that myself, I saw the A in place of the C100 from the previous test's command.

Loading

@SalmonMode SalmonMode changed the title [WIP] Add support for getting commits of line range Add support for getting commits of line range Oct 2, 2020
@hipstersmoothie hipstersmoothie merged commit f26a134 into domharrington:master Oct 2, 2020
@hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Oct 2, 2020

🚀 PR was released in v4.0.2 🚀

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants