Add Color Support #6

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@eriktjacobsen

Not well formatted, but basics of adding color into the output when it is piped to a tty(isatty returns false when output is piped to another process like grep)

@dominictarr

This comment has been minimized.

Show comment Hide comment
@dominictarr

dominictarr Oct 27, 2011

Owner

this is pretty cool,
but I'm afraid that I cannot pull this as is.

I'm planning on decoupling the code that handles the parse events, by injecting new code via variables,

much like in this: https://gist.github.com/1209534#file_bash_xml.bash

which will make it easy to add color support, as well as many other options.

I might not have a chance to implement that for a few days,
but if you want to implement it that way, then I will gladly pull.

Owner

dominictarr commented Oct 27, 2011

this is pretty cool,
but I'm afraid that I cannot pull this as is.

I'm planning on decoupling the code that handles the parse events, by injecting new code via variables,

much like in this: https://gist.github.com/1209534#file_bash_xml.bash

which will make it easy to add color support, as well as many other options.

I might not have a chance to implement that for a few days,
but if you want to implement it that way, then I will gladly pull.

@dominictarr dominictarr closed this Oct 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment