GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
As mentioned in #15
I hate to be that guy but a fresh pull request means a fresh branch off master, with only the changes discussed in it - not just the github form.
so that this can be merged cleanly...
So you want me to rebase away the noise?
Set#onEach will call the callback with all rows and any new row
that comes into existance
this isn't a callback! a callback is called exactly once, and always has (err, ....)
this variable is should be called iterator or listener, since onEach does both iteration and listening, so i'd accept either.
Of course, this function is only 3 lines long, but as a matter of principle...
naming things well is actually important.
Agreed. It's not a callback.
merged into 3.4.0