Emit `remove` on a row when it's removed #32

Merged
merged 1 commit into from Dec 14, 2013

Projects

None yet

2 participants

@mmalecki
Contributor

No description provided.

Owner

does this resolve #30 ?

I know this seems obvious enough, but can you include a description as to the reason for the change,
so I know how you are using it?

As a module author, you get very little feedback as to what your modules are actually being used for,
and how they are being used.

I think maybe the row should emit 'removed', since set already has a 'remove' event, that has the row as arguments.

Contributor

It kind of solves #30.

I was going to use it in knockout-crdt-observable-array to avoid doing this.

removed indeed sounds better. I'll amend and push.

@dominictarr dominictarr merged commit d478497 into dominictarr:master Dec 14, 2013
Owner

cool, this is merged into 3.6.0 !

@mmalecki mmalecki deleted the mmalecki:emit-remove-on-doc branch Dec 14, 2013
Contributor

awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment