Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defaultPager option #5

Closed
wants to merge 1 commit into from

Conversation

sumbach
Copy link
Contributor

@sumbach sumbach commented Feb 8, 2016

See also denysdovhan/bash-handbook#46.

This PR adds a defaultPager option (perhaps we could give this a better, less ambiguous name) to allow overriding the default of more. The difference between defaultPager and pager is that pager takes precedence over the $PAGER environment variable, whereas defaultPager is only used when $PAGER is not set.

@eush77
Copy link
Collaborator

eush77 commented Feb 8, 2016

I think having both pager and defaultPager is very confusing. Can you use something like

pager({ pager: process.env.PAGER || 'default-pager' })

instead?

@sumbach
Copy link
Contributor Author

sumbach commented Feb 9, 2016

@eush77 Good call; I ended up setting default values for PAGER and LESS (to match git behavior) instead of making a change to default-pager: https://github.com/denysdovhan/bash-handbook/pull/46/files

@sumbach sumbach closed this Feb 9, 2016
@sumbach sumbach deleted the defaultPager-option branch February 9, 2016 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants