New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge at end of chain doesn't complete task #101

Closed
stevenvachon opened this Issue Sep 16, 2016 · 4 comments

Comments

Projects
None yet
4 participants
@stevenvachon

stevenvachon commented Sep 16, 2016

const es = require("event-stream");

function css() {
  const docs = gulp.src("./less/docs.less")
    .pipe( less(lessOptions) )
    .pipe( concat("docs.css") )
    .pipe( gulp.dest("./docs/") );

  const framework = gulp.src("./less/framework.less")
    .pipe( less(lessOptions) )
    .pipe( concat("framework.css") )
    .pipe( gulp.dest("./build/") )
    .pipe( gulp.dest("./docs/") );

  return es.merge(docs, framework);
}
[14:08:35] The following tasks did not complete: css
[14:08:35] Did you forget to signal async completion?

It completes the task, however, when followed by another pipe in the chain:

return es.merge(docs, framework)
  .pipe( gulp.dest("./docs/") );
@stevenvachon

This comment has been minimized.

stevenvachon commented Sep 20, 2016

@dominictarr ?

merge-stream works, though -- switching to that.

@roydukkey

This comment has been minimized.

roydukkey commented Aug 7, 2018

I believe this is the same issue. https://stackoverflow.com/questions/51255885

@Kocal

This comment has been minimized.

Kocal commented Aug 21, 2018

It happens to me after updating to Gulp 4.
Thanks @stevenvachon for opening an issue and giving a solution 😎

@right9ctrl

This comment has been minimized.

Collaborator

right9ctrl commented Sep 6, 2018

Added note for gulp users in readme.

@right9ctrl right9ctrl closed this Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment