New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`readArray` and `writeArray` are confusing names? #50

Closed
bewest opened this Issue Jan 26, 2014 · 1 comment

Comments

Projects
None yet
3 participants
@bewest

bewest commented Jan 26, 2014

What do you think of aliasing them to head or prime and tail or collect, respectively.

It's not clear from the method names or the docs what these do, but they are common use cases:

  • start this stream with a bunch of data I have right now
  • collect all data in a results array and wait for done/end event

I'm catching a lot of authors still attempting to manage on.data(function (data) { results.push(data); }) and similar end stanzas by hand instead of using these friendly methods and simply pipelining appropriately configured streams. My proposal is that somehow making these two methods more clear in particular would help people.

@dominictarr

This comment has been minimized.

Owner

dominictarr commented Jan 27, 2014

collect is good, I don't see head or prime though.

@right9ctrl right9ctrl closed this Sep 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment