New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access to stream combiner #81

Closed
eddieajau opened this Issue Jan 22, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@eddieajau

eddieajau commented Jan 22, 2015

Just wondering, the stream-combiner module is accessible via es.pipe but it's not exposed in the documentation. Is it safe to use es.pipe in our code?

Thanks in advance.

@dominictarr

This comment has been minimized.

Owner

dominictarr commented Jan 26, 2015

that is a legacy api, but it's not gonna change.

@dominictarr

This comment has been minimized.

Owner

dominictarr commented Jan 26, 2015

so yes.

@eddieajau

This comment has been minimized.

eddieajau commented Jan 26, 2015

Ok, thanks.

Would it be better practice to add the stream-combiner as an explicit dependency, or is it a case of it doesn't matter for now?

@dominictarr

This comment has been minimized.

Owner

dominictarr commented Jan 26, 2015

well, I'm not gonna remove es.pipe from event-stream so it would be safe to do so, but if it was my code I'd just depend on stream-combiner directly.

@eddieajau

This comment has been minimized.

eddieajau commented Jan 26, 2015

Perfect. That's what I wanted to know. Thanks so much. Your modules have been a life saver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment