New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add go-guru-definition-other-window #176
Conversation
Adds go-guru-definition-other-window that opens the defintion of the target in another window. Equivalent to godef-jump-other-window. Fixes dominikh#175
@@ -319,11 +319,11 @@ If BUFFER, return the number of characters in that buffer instead." | |||
"Go to the OFFSETth byte in the current line." | |||
(goto-char (byte-to-position (+ (position-bytes (point-at-bol)) (1- offset))))) | |||
|
|||
(defun go-guru--goto-pos (posn) | |||
(defun go-guru--goto-pos (posn other-window) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is passing function better than passing flag value ? If its argument is function, we can pass other find-file
function like find-function-other-frame
etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dominikh what's your opinion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now: KISS.
Ping! |
Sorry, I'll look into this in the next couple of days. |
Ping |
Hey, sorry for the delay. I'll look at it as soon as I can, though I'm not sure when that'll be :-( |
Gentle ping! |
Merged as 3f02a16, thank you. |
Thanks! |
Adds go-guru-definition-other-window that opens the defintion of the
target in another window. Equivalent to godef-jump-other-window.
Fixes #175