SA1019: apply Go version filtering to imports #1117

dominikh · 2021-11-06T01:13:39Z

Depending on why and when an object in the standard library has been deprecated, we won't flag it when targeting certain Go versions. We don't currently apply the same logic to imports. This hasn't been a problem yet, because

crypto/md4 should never be used and would always be flagged, anyway
io/ioutil doesn't have the deprecated marker, and even though we've manually marked it as deprecated in our database, we don't flag it, because we don't consult the database for imports yet.

We should nevertheless fix this and prepare for the future.

Closes gh-1117

Closes gh-1117 (cherry picked from commit 04e5718)

dominikh added the false-positive label Nov 6, 2021

dominikh mentioned this issue Apr 1, 2022

SA1019: apply stdlib-specific logic to imports, too #1214

Closed

dominikh added a commit that referenced this issue Apr 25, 2022

SA1019: apply Go version filtering to imports, too

d9ecc38

Closes gh-1117

dominikh closed this as completed in 04e5718 Apr 25, 2022

dominikh added a commit that referenced this issue May 16, 2022

SA1019: apply Go version filtering to imports, too

7908c9b

Closes gh-1117 (cherry picked from commit 04e5718)

dominikh added a commit that referenced this issue May 16, 2022

SA1019: apply Go version filtering to imports, too

8f50df0

Closes gh-1117 (cherry picked from commit 04e5718)

SA1019: apply Go version filtering to imports #1117

SA1019: apply Go version filtering to imports #1117

Comments

dominikh commented Nov 6, 2021