Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SA1019: apply Go version filtering to imports #1117

Closed
dominikh opened this issue Nov 6, 2021 · 0 comments
Closed

SA1019: apply Go version filtering to imports #1117

dominikh opened this issue Nov 6, 2021 · 0 comments

Comments

@dominikh
Copy link
Owner

@dominikh dominikh commented Nov 6, 2021

Depending on why and when an object in the standard library has been deprecated, we won't flag it when targeting certain Go versions. We don't currently apply the same logic to imports. This hasn't been a problem yet, because

  • crypto/md4 should never be used and would always be flagged, anyway
  • io/ioutil doesn't have the deprecated marker, and even though we've manually marked it as deprecated in our database, we don't flag it, because we don't consult the database for imports yet.

We should nevertheless fix this and prepare for the future.

dominikh added a commit that referenced this issue May 16, 2022
dominikh added a commit that referenced this issue May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant