SciMLStyle #588
Merged
SciMLStyle #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 23, 2022
domluna
approved these changes
May 24, 2022
| iter += 1 | ||
| end | ||
| return formatted_text | ||
| end |
Contributor
There was a problem hiding this comment.
That feels quite hacky? Also, not clear how this would interact with a potential partial formatting in an IDE? Wouldn't it make sense to require that a second call to format_text is always a no-op?
domluna
reviewed
May 25, 2022
Comment on lines
+558
to
+559
| # We need to iterate to a fixpoint because the result of short to long | ||
| # form isn't properly formatted |
Owner
There was a problem hiding this comment.
maybe we should just make this part work properly then we wouldn't have to do this
Contributor
Author
There was a problem hiding this comment.
Owner
There was a problem hiding this comment.
ok made an issue to track it, since this is function is only applicable to SciMLStyle this is fine for now.
Merged
This was referenced Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.