Skip to content
This repository

Please release 0.86 #2

Merged
merged 5 commits into from almost 3 years ago

2 participants

Reini Urban Alexandr Ciornii
Reini Urban
rurban commented July 14, 2011

and please not on Windows as 0.85. DOS eol is not appreciated.

Alexandr Ciornii
Collaborator

Is this restriction necessary for something?

Yes. If you have symlinks in your working dir, which are no in MANIFEST. Some private helper scripts e.g.

Reini Urban
rurban commented July 15, 2011

The no_symlink check fails for me with symlinks in my dirs for common scripts which are not in MANIFEST.
Thus the kwalitee test fails, where it should not fail.

Reini Urban rurban closed this July 15, 2011
Alexandr Ciornii chorny reopened this July 16, 2011
Alexandr Ciornii chorny merged commit 159e0d1 into from July 16, 2011
Alexandr Ciornii chorny closed this July 16, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
6  Module-CPANTS-Analyse/Build.PL
@@ -9,13 +9,14 @@ my $build = Module::Build->new(
9 9
         'Archive::Any'              => '0.06',
10 10
         'Archive::Tar'              => '1.30',
11 11
         'CPAN::DistnameInfo'        => '0.06',
  12
+	'ExtUtils::Manifest'        => '1.33',
12 13
         'Pod::Simple::Checker'      => '2.02',
13  
-        'YAML::Syck'                => '0.95',
  14
+        'YAML::Any'                 => '0.72',
14 15
         'Module::ExtractUse'        => '0.18',
15 16
         'Module::Pluggable'         => '2.96',
16 17
         'IO::Capture'               => '0.05',
17 18
         'Array::Diff'               => '0.04',
18  
-        'Test::YAML::Meta::Version' => '0.13', #Some errors fixed
  19
+	'Test::CPAN::Meta::YAML'    => '0.17',
19 20
         'version'                   => '0.73',
20 21
         'List::MoreUtils'           => '0',
21 22
         'File::Find::Rule'          => '0',
@@ -27,6 +28,7 @@ my $build = Module::Build->new(
27 28
         'perl'                      => 5.006,
28 29
     },
29 30
     build_requires => {
  31
+	'Module::Build'             => '0.38',
30 32
         'Test::More'                => '0',
31 33
         'Test::Deep'                => '0',
32 34
         'Test::Warn'                => '0.11', #less problems with new Sub::Uplevel
13  Module-CPANTS-Analyse/Changes
@@ -2,10 +2,15 @@
2 2
 # Changes for Module::CPANTS::Analyse
3 3
 #-----------------------------------------------------------------
4 4
 
5  
-    - fix when Moose is used and strict is not used
6  
-    - add info about MIN_PERL_VERSION
7  
-    - better remedy for 'metayml_declares_perl_version'
8  
-    - 'metayml_declares_perl_version' moved from experimental to extra
  5
+0.86   2011-07-15, Reini Urban
  6
+    - replace Test::YAML::Meta::Version with Test::CPAN::Meta::YAML::Version (rurban)
  7
+    - replace YAML::Syck with YAML::Any (rurban)
  8
+    - no_symlinks checks only files in MANIFEST, use ExtUtils::Manifest::maniread (rurban)
  9
+    - added test 'has_better_auto_install' (ciorni)
  10
+    - fix when Moose is used and strict is not used (ciorni)
  11
+    - add info about MIN_PERL_VERSION (ciorni)
  12
+    - better remedy for 'metayml_declares_perl_version' (ciorni)
  13
+    - 'metayml_declares_perl_version' moved from experimental to extra (ciorni)
9 14
 
10 15
 0.85    2009-07-12, Alexandr Ciornii
11 16
     - fix fails on non-Win32
1  Module-CPANTS-Analyse/MANIFEST
@@ -66,3 +66,4 @@ xt/99_critic.t
66 66
 xt/99_pod.t
67 67
 xt/99_pod_coverage.t
68 68
 Makefile.PL
  69
+META.json
96  Module-CPANTS-Analyse/META.yml
... ...
@@ -1,82 +1,100 @@
1 1
 ---
2  
-name: Module-CPANTS-Analyse
3  
-version: 0.85
  2
+abstract: 'Generate Kwalitee ratings for a distribution'
4 3
 author:
5 4
   - 'Thomas Klausner, <domm@cpan.org>, http://domm.zsi.at'
6  
-  - |-
7  
-    Based on work by Leon Brocard <acme@astray.com> and the original idea
8  
-    proposed by Michael G. Schwern <schwern@pobox.com>
9  
-abstract: Generate Kwalitee ratings for a distribution
10  
-license: perl
11  
-resources:
12  
-  license: http://dev.perl.org/licenses/
13  
-  repository: http://github.com/domm/CPANTS/tree
14  
-requires:
15  
-  Archive::Any: 0.06
16  
-  Archive::Tar: 1.30
17  
-  Array::Diff: 0.04
18  
-  CPAN::DistnameInfo: 0.06
19  
-  Class::Accessor: 0.19
20  
-  File::Find::Rule: 0
21  
-  File::Slurp: 0
22  
-  IO::Capture: 0.05
23  
-  LWP::Simple: 0
24  
-  List::MoreUtils: 0
25  
-  Module::ExtractUse: 0.18
26  
-  Module::Pluggable: 2.96
27  
-  Pod::Simple::Checker: 2.02
28  
-  Readonly: 0
29  
-  Software::License: 0.003
30  
-  Test::YAML::Meta::Version: 0.11
31  
-  Text::CSV_XS: 0.45
32  
-  YAML::Syck: 0.95
33  
-  perl: 5.006
34  
-  version: 0.73
  5
+  - "Based on work by Leon Brocard <acme@astray.com> and the original idea\nproposed by Michael G. Schwern <schwern@pobox.com>"
35 6
 build_requires:
36 7
   Test::Deep: 0
37 8
   Test::More: 0
38 9
   Test::NoWarnings: 0
39 10
   Test::Warn: 0.11
  11
+configure_requires:
  12
+  Module::Build: 0.38
  13
+dynamic_config: 1
  14
+generated_by: 'Module::Build version 0.38, CPAN::Meta::Converter version 2.110440'
  15
+keywords:
  16
+  - CPANTS
  17
+  - kwalitee
  18
+license: perl
  19
+meta-spec:
  20
+  url: http://module-build.sourceforge.net/META-spec-v1.4.html
  21
+  version: 1.4
  22
+name: Module-CPANTS-Analyse
40 23
 provides:
41 24
   Module::CPANTS::Analyse:
42 25
     file: lib/Module/CPANTS/Analyse.pm
43  
-    version: 0.85
  26
+    version: 0.86
44 27
   Module::CPANTS::Kwalitee:
45 28
     file: lib/Module/CPANTS/Kwalitee.pm
  29
+    version: 0
46 30
   Module::CPANTS::Kwalitee::BrokenInstaller:
47 31
     file: lib/Module/CPANTS/Kwalitee/BrokenInstaller.pm
  32
+    version: 0
48 33
   Module::CPANTS::Kwalitee::CpantsErrors:
49 34
     file: lib/Module/CPANTS/Kwalitee/CpantsErrors.pm
  35
+    version: 0
50 36
   Module::CPANTS::Kwalitee::Distname:
51 37
     file: lib/Module/CPANTS/Kwalitee/Distname.pm
  38
+    version: 0
52 39
   Module::CPANTS::Kwalitee::Distros:
53 40
     file: lib/Module/CPANTS/Kwalitee/Distros.pm
  41
+    version: 0
54 42
   Module::CPANTS::Kwalitee::Files:
55 43
     file: lib/Module/CPANTS/Kwalitee/Files.pm
  44
+    version: 0
56 45
   Module::CPANTS::Kwalitee::FindModules:
57 46
     file: lib/Module/CPANTS/Kwalitee/FindModules.pm
  47
+    version: 0
58 48
   Module::CPANTS::Kwalitee::License:
59 49
     file: lib/Module/CPANTS/Kwalitee/License.pm
  50
+    version: 0
60 51
   Module::CPANTS::Kwalitee::Manifest:
61 52
     file: lib/Module/CPANTS/Kwalitee/Manifest.pm
  53
+    version: 0
62 54
   Module::CPANTS::Kwalitee::MetaYML:
63 55
     file: lib/Module/CPANTS/Kwalitee/MetaYML.pm
  56
+    version: 0
64 57
   Module::CPANTS::Kwalitee::NeedsCompiler:
65 58
     file: lib/Module/CPANTS/Kwalitee/NeedsCompiler.pm
  59
+    version: 0
66 60
   Module::CPANTS::Kwalitee::Pod:
67 61
     file: lib/Module/CPANTS/Kwalitee/Pod.pm
  62
+    version: 0
68 63
   Module::CPANTS::Kwalitee::Prereq:
69 64
     file: lib/Module/CPANTS/Kwalitee/Prereq.pm
  65
+    version: 0
70 66
   Module::CPANTS::Kwalitee::Repackageable:
71 67
     file: lib/Module/CPANTS/Kwalitee/Repackageable.pm
  68
+    version: 0
72 69
   Module::CPANTS::Kwalitee::Uses:
73 70
     file: lib/Module/CPANTS/Kwalitee/Uses.pm
  71
+    version: 0
74 72
   Module::CPANTS::Kwalitee::Version:
75 73
     file: lib/Module/CPANTS/Kwalitee/Version.pm
76  
-generated_by: Module::Build version 0.33
77  
-meta-spec:
78  
-  url: http://module-build.sourceforge.net/META-spec-v1.4.html
79  
-  version: 1.4
80  
-keywords:
81  
-  - CPANTS
82  
-  - kwalitee
  74
+    version: 0
  75
+requires:
  76
+  Archive::Any: 0.06
  77
+  Archive::Tar: 1.30
  78
+  Array::Diff: 0.04
  79
+  CPAN::DistnameInfo: 0.06
  80
+  Class::Accessor: 0.19
  81
+  ExtUtils::Manifest: 1.33
  82
+  File::Find::Rule: 0
  83
+  File::Slurp: 0
  84
+  IO::Capture: 0.05
  85
+  LWP::Simple: 0
  86
+  List::MoreUtils: 0
  87
+  Module::ExtractUse: 0.18
  88
+  Module::Pluggable: 2.96
  89
+  Pod::Simple::Checker: 2.02
  90
+  Readonly: 0
  91
+  Software::License: 0.003
  92
+  Test::CPAN::Meta::YAML: 0.17
  93
+  Text::CSV_XS: 0.45
  94
+  YAML::Any: 0.72
  95
+  perl: 5.006
  96
+  version: 0.73
  97
+resources:
  98
+  license: http://dev.perl.org/licenses/
  99
+  repository: http://github.com/domm/CPANTS/tree
  100
+version: 0.86
2  Module-CPANTS-Analyse/bin/cpants_lint.pl
@@ -5,7 +5,7 @@
5 5
 use Getopt::Long;
6 6
 use IO::Capture::Stdout;
7 7
 use Data::Dumper;
8  
-use YAML::Syck;
  8
+use YAML::Any;
9 9
 use File::Spec::Functions;
10 10
 use Cwd;
11 11
 use Pod::Usage;
4  Module-CPANTS-Analyse/lib/Module/CPANTS/Analyse.pm
@@ -11,9 +11,9 @@ use Carp;
11 11
 use Module::CPANTS::Kwalitee;
12 12
 use IO::Capture::Stdout;
13 13
 use IO::Capture::Stderr;
14  
-use YAML::Syck qw(LoadFile);
  14
+use YAML::Any qw(LoadFile);
15 15
 
16  
-use version; our $VERSION=version->new('0.85');
  16
+use version; our $VERSION=version->new('0.86');
17 17
 
18 18
 # setup logger
19 19
 if (! main->can('logger')) {
8  Module-CPANTS-Analyse/lib/Module/CPANTS/Kwalitee/Files.pm
@@ -9,6 +9,7 @@ use Data::Dumper;
9 9
 use Readonly;
10 10
 use Software::LicenseUtils;
11 11
 use File::Slurp            qw(slurp);
  12
+use ExtUtils::Manifest;
12 13
 
13 14
 sub order { 10 }
14 15
 
@@ -60,11 +61,14 @@ sub analyse {
60 61
     $me->d->{size_unpacked}=$size;
61 62
 
62 63
     # find symlinks
  64
+    my $manifest = -f catfile($distdir, 'MANIFEST')
  65
+                   ? ExtUtils::Manifest::maniread(catfile($distdir, 'MANIFEST'))
  66
+		   : {};
63 67
     my @symlinks;
64 68
     foreach my $f (@dirs, @files) {
65  
-        my $p=catfile($distdir,$f);
  69
+        my $p = catfile($distdir,$f);
66 70
         if (-l $f) {
67  
-            push(@symlinks,$f);
  71
+            push(@symlinks,$f) if $manifest and exists $manifest->{$f};
68 72
         }
69 73
     }
70 74
 
6  Module-CPANTS-Analyse/lib/Module/CPANTS/Kwalitee/MetaYML.pm
@@ -2,8 +2,8 @@ package Module::CPANTS::Kwalitee::MetaYML;
2 2
 use warnings;
3 3
 use strict;
4 4
 use File::Spec::Functions qw(catfile);
5  
-use YAML::Syck qw(Load LoadFile);
6  
-use Test::YAML::Meta::Version;
  5
+use YAML::Any qw(Load LoadFile);
  6
+use Test::CPAN::Meta::YAML;
7 7
 
8 8
 sub order { 20 }
9 9
 
@@ -149,7 +149,7 @@ sub check_spec_conformance {
149 149
         }
150 150
     }
151 151
     $hash{spec} = $version;
152  
-    my $spec = Test::YAML::Meta::Version->new(%hash);
  152
+    my $spec = Test::CPAN::Meta::YAML::Version->new(%hash);
153 153
     if ($spec->parse()) {
154 154
         my $report_version= $version || 'known';
155 155
         my @errors;
2  Module-CPANTS-Analyse/t/02_kwalitee.t
@@ -4,7 +4,7 @@ use Test::NoWarnings;
4 4
 
5 5
 use Module::CPANTS::Kwalitee;
6 6
 
7  
-my $CORE = 23;
  7
+my $CORE = 24;
8 8
 my $OPTIONAL = 10; #is_extra set
9 9
 my $EXTRA = 15; #experimental?
10 10
 my $METRICS = $CORE + $OPTIONAL + $EXTRA;
21  Module-CPANTS-Analyse/t/10_analyse.t
@@ -28,12 +28,13 @@ my @tests = (
28 28
            'metayml_declares_perl_version' => 0,
29 29
            'has_example' => 1,
30 30
            'has_test_pod_coverage' => 1,
  31
+	   'has_better_auto_install' => 1,
31 32
            'metayml_is_parsable' => 1,
32 33
            'proper_libs' => 1,
33 34
            'has_changelog' => 1,
34 35
            'no_pod_errors' => 1,
35 36
            'use_strict' => 1,
36  
-           'kwalitee' => 39,
  37
+           'kwalitee' => 40,
37 38
            'no_stdin_for_prompting' => 1,
38 39
            'has_test_pod' => 1,
39 40
            'easily_repackageable' => 1,
@@ -84,12 +85,13 @@ my @tests = (
84 85
            'metayml_declares_perl_version' => 0,
85 86
            'has_example' => 0,
86 87
            'has_test_pod_coverage' => 1,
  88
+	   'has_better_auto_install' => 1,
87 89
            'metayml_is_parsable' => 0,
88 90
            'proper_libs' => 1,
89 91
            'has_changelog' => 1,
90 92
            'no_pod_errors' => 1,
91 93
            'use_strict' => 1,
92  
-           'kwalitee' => 28,
  94
+           'kwalitee' => 29,
93 95
            'no_stdin_for_prompting' => 1,
94 96
            'has_test_pod' => 1,
95 97
            'easily_repackageable' => 0,
@@ -178,12 +180,13 @@ my @tests = (
178 180
            'metayml_declares_perl_version' => 1,
179 181
            'has_example' => 1,
180 182
            'has_test_pod_coverage' => 0,
  183
+	   'has_better_auto_install' => 1,
181 184
            'metayml_is_parsable' => 1,
182 185
            'proper_libs' => 1,
183 186
            'has_changelog' => 1,
184 187
            'no_pod_errors' => 1,
185 188
            'use_strict' => 1,
186  
-           'kwalitee' => 36,
  189
+           'kwalitee' => 37,
187 190
            'no_stdin_for_prompting' => 1,
188 191
            'has_test_pod' => 1,
189 192
            'easily_repackageable' => 1,
@@ -237,12 +240,13 @@ my @tests = (
237 240
            'metayml_declares_perl_version' => 0,
238 241
            'has_example' => 1,
239 242
            'has_test_pod_coverage' => 1,
  243
+	   'has_better_auto_install' => 1,
240 244
            'metayml_is_parsable' => 1,
241 245
            'proper_libs' => 1,
242 246
            'has_changelog' => 1,
243 247
            'no_pod_errors' => 1,
244 248
            'use_strict' => 1,
245  
-           'kwalitee' => 37,
  249
+           'kwalitee' => 38,
246 250
            'no_stdin_for_prompting' => 1,
247 251
            'has_test_pod' => 1,
248 252
            'easily_repackageable' => 1,
@@ -292,13 +296,14 @@ my @tests = (
292 296
            'metayml_declares_perl_version' => 1,
293 297
            'has_example' => 0,
294 298
            'has_test_pod_coverage' => 1,
  299
+	   'has_better_auto_install' => 1,
295 300
            'has_no_patches_in_debian' => 0,
296 301
            'metayml_is_parsable' => 1,
297 302
            'proper_libs' => 1,
298 303
            'has_changelog' => 1,
299 304
            'no_pod_errors' => 1,
300 305
            'use_strict' => 1,
301  
-           'kwalitee' => 39,
  306
+           'kwalitee' => 40,
302 307
            'no_stdin_for_prompting' => 1,
303 308
            'has_license_in_source_file' => 1,
304 309
            'has_test_pod' => 1,
@@ -345,13 +350,14 @@ my @tests = (
345 350
            'metayml_declares_perl_version' => 0,
346 351
            'has_example' => 0,
347 352
            'has_test_pod_coverage' => 1,
  353
+	   'has_better_auto_install' => 1,
348 354
            'has_no_patches_in_debian' => 0,
349 355
            'metayml_is_parsable' => 1,
350 356
            'proper_libs' => 1,
351 357
            'has_changelog' => 1,
352 358
            'no_pod_errors' => 1,
353 359
            'use_strict' => 1,
354  
-           'kwalitee' => 37,
  360
+           'kwalitee' => 38,
355 361
            'no_stdin_for_prompting' => 1,
356 362
            'has_license_in_source_file' => 1,
357 363
            'has_test_pod' => 1,
@@ -398,13 +404,14 @@ my @tests = (
398 404
            'metayml_declares_perl_version' => 1,
399 405
            'has_example' => 1,
400 406
            'has_test_pod_coverage' => 1,
  407
+	   'has_better_auto_install' => 1,
401 408
            'has_no_patches_in_debian' => 0,
402 409
            'metayml_is_parsable' => 1,
403 410
            'proper_libs' => 1,
404 411
            'has_changelog' => 1,
405 412
            'no_pod_errors' => 1,
406 413
            'use_strict' => 1,
407  
-           'kwalitee' => 40,
  414
+           'kwalitee' => 41,
408 415
            'no_stdin_for_prompting' => 1,
409 416
            'has_license_in_source_file' => 1,
410 417
            'has_test_pod' => 1,
3  Module-CPANTS-Analyse/t/calc.t
@@ -41,13 +41,14 @@ my $expected_kwalitee =  {
41 41
            'manifest_matches_dist' => 1,
42 42
            'has_example' => 1,
43 43
            'has_test_pod_coverage' => 1,
  44
+	   'has_better_auto_install' => 1,
44 45
            'metayml_is_parsable' => 1,
45 46
            'easily_repackageable' => 0,
46 47
            'proper_libs' => 1,
47 48
            'has_changelog' => 1,
48 49
            'no_pod_errors' => 1,
49 50
            'use_strict' => 1,
50  
-           'kwalitee' => 28,
  51
+           'kwalitee' => 29,
51 52
            'has_test_pod' => 1,
52 53
            'has_tests' => 1,
53 54
            'easily_repackageable_by_debian' => 1,
3  Module-CPANTS-Analyse/t/calc_test_yaml_meta.t
@@ -37,13 +37,14 @@ my $expected_kwalitee = {
37 37
            'manifest_matches_dist' => 1,
38 38
            'has_example' =>1,             
39 39
            'has_test_pod_coverage' => 1,
  40
+	   'has_better_auto_install' => 1,
40 41
            'metayml_is_parsable' => 1,
41 42
            'easily_repackageable' => 1,
42 43
            'proper_libs' => 1,
43 44
            'has_changelog' => 1,
44 45
            'no_pod_errors' => 1,
45 46
            'use_strict' => 1,
46  
-           'kwalitee' => 39,
  47
+           'kwalitee' => 40,
47 48
            'has_test_pod' => 1,
48 49
            'has_tests' => 1,
49 50
            'easily_repackageable_by_debian' => 1,
3  Module-CPANTS-Analyse/t/generated_files.t
@@ -22,12 +22,13 @@ my $expected = {
22 22
            'metayml_declares_perl_version' => 0,
23 23
            'has_example' => 1,
24 24
            'has_test_pod_coverage' => 1,
  25
+	   'has_better_auto_install' => 1,
25 26
            'metayml_is_parsable' => 1,
26 27
            'proper_libs' => 1,
27 28
            'has_changelog' => 1,
28 29
            'no_pod_errors' => 1,
29 30
            'use_strict' => 1,
30  
-           'kwalitee' => 26,
  31
+           'kwalitee' => 27,
31 32
            'no_stdin_for_prompting' => 1,
32 33
            'has_test_pod' => 1,
33 34
            'easily_repackageable' => 0,
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.