Fixes for Turkish translation files. #314
Conversation
krmgns
changed the title
| @@ -17,7 +17,7 @@ msgstr "Entity-Attribute-Value (Varlık-Özellik-Değer)" | |||
|
|
|||
| #: ../../More/EAV/README.rst:4 | |||
| msgid "The Entity–attribute–value (EAV) pattern in order to implement EAV model with PHP." | |||
| msgstr "" | |||
| msgstr "-" | |||
There was a problem hiding this comment.
'Cos it does not add anything to translation. It sounds EAV is EAV.
There was a problem hiding this comment.
@k-gun first of all. If you put "-" in msgstr then this whole sentence "The Entity–attribute–value (EAV) pattern in order to implement EAV model with PHP." will be translated into "-" - this is not cool. Other thing is that this msgid is not a shortcut only but full sentence that should be translated as well.
| @@ -50,7 +50,7 @@ msgstr "" | |||
|
|
|||
| #: ../../More/Repository/README.rst:20 | |||
| msgid "Laravel Framework" | |||
| msgstr "" | |||
| msgstr "Aptal bir framework." | |||
There was a problem hiding this comment.
why translate Laravel Framework? It's a name.
There was a problem hiding this comment.
What! Translation says, 'It is a stupid framework.' ??
|
Closing this as there was no more action on this and it seems that this adds little value and breaks translations as @piotrgradzinski mentioned. |
|
Emmanuel Lamblin
Le vendredi 22 décembre 2017 à 02:16:58 UTC+1, Kerem Güneş <notifications@github.com> a écrit :
@k-gun commented on this pull request.
In locale/tr/LC_MESSAGES/More/EAV/README.po:
@@ -17,7 +17,7 @@ msgstr "Entity-Attribute-Value (Varlık-Özellik-Değer)"
#: ../../More/EAV/README.rst:4
msgid "The Entity–attribute–value (EAV) pattern in order to implement EAV model with PHP."
-msgstr ""
+msgstr "-"
'Cos it does not add anything to translation. It sounds EAV is EAV.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
No description provided.