Retina icon #58

Closed
tmcw opened this Issue Feb 27, 2014 · 13 comments

Comments

Projects
None yet
2 participants
@tmcw
Contributor

tmcw commented Feb 27, 2014

Right now there's a @1x icon & SVG files. Should be a pretty quick task to render out a @2x icon for this. Will do when I get a moment.

@domoritz

This comment has been minimized.

Show comment Hide comment
@domoritz

domoritz Feb 27, 2014

Owner

Yes, since there is the SVG file it should be straightforward. The different colors are in layers and I used Inkscape to create the SVG.

Owner

domoritz commented Feb 27, 2014

Yes, since there is the SVG file it should be straightforward. The different colors are in layers and I used Inkscape to create the SVG.

@domoritz

This comment has been minimized.

Show comment Hide comment
@domoritz

domoritz Feb 27, 2014

Owner

Why not generate a web font with vector versions and even animate the spinner using CSS? This would allow even setting the color of the icons.

Owner

domoritz commented Feb 27, 2014

Why not generate a web font with vector versions and even animate the spinner using CSS? This would allow even setting the color of the icons.

@tmcw

This comment has been minimized.

Show comment Hide comment
@tmcw

tmcw Feb 27, 2014

Contributor

I would rather go for the simple way first :)

Contributor

tmcw commented Feb 27, 2014

I would rather go for the simple way first :)

@domoritz

This comment has been minimized.

Show comment Hide comment
@domoritz

domoritz Feb 27, 2014

Owner

Agreed. But would be nice anyway. I could look into web fonts as I don't have a retina device and never created retina icons. Could you render the @2x icon and send a pr? Thanks!

Owner

domoritz commented Feb 27, 2014

Agreed. But would be nice anyway. I could look into web fonts as I don't have a retina device and never created retina icons. Could you render the @2x icon and send a pr? Thanks!

@tmcw

This comment has been minimized.

Show comment Hide comment
@tmcw

tmcw Feb 27, 2014

Contributor

Yep, #59

Contributor

tmcw commented Feb 27, 2014

Yep, #59

@tmcw

This comment has been minimized.

Show comment Hide comment
@tmcw

tmcw Feb 27, 2014

Contributor

Thx for merging - can you tag a release and I'll update the cdn?

Contributor

tmcw commented Feb 27, 2014

Thx for merging - can you tag a release and I'll update the cdn?

@domoritz

This comment has been minimized.

Show comment Hide comment
@domoritz

domoritz Feb 27, 2014

Owner

Thanks. I merged it and tagged it as https://github.com/domoritz/leaflet-locatecontrol/releases/tag/v0.24.0. Also, there is a new version with icon fonts and animation in css in https://github.com/domoritz/leaflet-locatecontrol/releases/tag/v0.25.0.

Could you link me to the CDN so that I can add it to the readme? It would be good if people could just copy and paste some html to get it working without having to download the files.

Owner

domoritz commented Feb 27, 2014

Thanks. I merged it and tagged it as https://github.com/domoritz/leaflet-locatecontrol/releases/tag/v0.24.0. Also, there is a new version with icon fonts and animation in css in https://github.com/domoritz/leaflet-locatecontrol/releases/tag/v0.25.0.

Could you link me to the CDN so that I can add it to the readme? It would be good if people could just copy and paste some html to get it working without having to download the files.

@domoritz

This comment has been minimized.

Show comment Hide comment
@domoritz

domoritz Feb 27, 2014

Owner

Oh, I just saw the link ;-) Is there a way to update the CDN automatically?

Owner

domoritz commented Feb 27, 2014

Oh, I just saw the link ;-) Is there a way to update the CDN automatically?

@domoritz domoritz closed this Feb 27, 2014

@domoritz

This comment has been minimized.

Show comment Hide comment
@domoritz

domoritz Apr 29, 2015

Owner

@tmcw I'd like to update the mapbox CDN. Currently this control is on version 41 but mapbox only has version 24.

Owner

domoritz commented Apr 29, 2015

@tmcw I'd like to update the mapbox CDN. Currently this control is on version 41 but mapbox only has version 24.

@tmcw

This comment has been minimized.

Show comment Hide comment
@tmcw

tmcw Apr 29, 2015

Contributor

If you pull-request adding the files to the mapbox.js-plugins repo I can run the deploy script.

Contributor

tmcw commented Apr 29, 2015

If you pull-request adding the files to the mapbox.js-plugins repo I can run the deploy script.

@domoritz

This comment has been minimized.

Show comment Hide comment
@domoritz

domoritz Apr 29, 2015

Owner

Thanks! That was what I was looking for.

Owner

domoritz commented Apr 29, 2015

Thanks! That was what I was looking for.

@domoritz

This comment has been minimized.

Show comment Hide comment
@domoritz

domoritz Apr 29, 2015

Owner

I sent a pr mapbox/mapbox.js-plugins#24. I don't know whether you want the full font awesome, though.

Owner

domoritz commented Apr 29, 2015

I sent a pr mapbox/mapbox.js-plugins#24. I don't know whether you want the full font awesome, though.

@tmcw

This comment has been minimized.

Show comment Hide comment
@tmcw

tmcw Apr 30, 2015

Contributor

👍 just deployed 0.42 and updated the site to point to it.

Contributor

tmcw commented Apr 30, 2015

👍 just deployed 0.42 and updated the site to point to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment