Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XSS vulnerability #3368

Closed
wants to merge 1 commit into from
Closed

Conversation

Frige1
Copy link

@Frige1 Frige1 commented Jul 1, 2019

XXS in Line 935. The item.Name was not escaped.

See Issue #3367

XXS in Line 935. The item.Name was not escaped.
@gizmocuz
Copy link
Contributor

gizmocuz commented Jul 3, 2019

Thanks for the PR.
Your current PR causes all scene names that includes for example spaces to be displayed with %20 in the name
Also names containing non-latin characters to display wrongly.

It also seems not possible to change a name to a non-latin name

Is there another solution ?

@gizmocuz
Copy link
Contributor

gizmocuz commented Jul 3, 2019

Maybe solved by using the encodeURIComponent/decodeuricomponent functions ?

@gizmocuz
Copy link
Contributor

Going to be solved differently (as discussed in the #3329

@gizmocuz gizmocuz closed this Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants