Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.8.4 milestone - Releasing early and often #2041

Closed
bkuhl opened this issue Jan 1, 2020 · 9 comments
Closed

0.8.4 milestone - Releasing early and often #2041

bkuhl opened this issue Jan 1, 2020 · 9 comments

Comments

@bkuhl
Copy link

@bkuhl bkuhl commented Jan 1, 2020

I'm concerned about updates here hindering my ability to upgrade to PHP 7.4 quickly. The past 2 releases for this package were almost a year apart. Currently the milestone for 0.8.4 contains 45 more open issues. There's a few issues here related to PHP 7.4 compatibility that releasing sooner rather than later, would add a decent amount of value to the community, allowing folks to proceed with upgrading to PHP 7.4 who don't need to take advantage of the other bug fixes. Is the team open to shipping a smaller release, containing smaller improvements/fixes?

@bsweeney bsweeney added this to the 0.8.4 milestone Jan 2, 2020
@bsweeney

This comment has been minimized.

Copy link
Member

@bsweeney bsweeney commented Jan 2, 2020

You're absolutely right. I keep telling myself I'm going to move more in this direction and yet, somehow, I've never quite gotten to the point where I feel I'm ready. Perhaps it's time I stop thinking big and focus more on incrementalism.

As for the 0.8.4 milestone, I'm actually planning to move any non-addressed issues to the dompdf-next milestone (the "working set" of potential issues for the next release). My goal was to finish reviewing the pull requests and once I've finished going through those release 0.8.4.

And maybe this is how I get to the "early and often" release scheme. Move everything that isn't ready to dompdf-next, go ahead and release 0.8.4, only add things that are ready to go for each future milestone, and release on a schedule (every other month or something like that).

@bsweeney

This comment has been minimized.

Copy link
Member

@bsweeney bsweeney commented Jan 2, 2020

OK, I went through and moved almost everything to dompdf-next. Maybe we can get 0.8.4 out the door.

@bkuhl

This comment has been minimized.

Copy link
Author

@bkuhl bkuhl commented Jan 2, 2020

I can't thank you enough for re-evaluating the release cycle for 7.4 compatibility. That plan sounds good!

This is a heavily used project because it solves a huge need and quite frankly makes PDF generation very easy. I just threw a small donation your way, anyone else can do the same here as well. Thanks for all the effort you and the team have put in on this project and being open to feedback on the release schedule!

@gbrunacci

This comment has been minimized.

Copy link

@gbrunacci gbrunacci commented Jan 8, 2020

+1 to this, I heavily depend on this.

@bsweeney bsweeney mentioned this issue Jan 11, 2020
@LasseRafn

This comment has been minimized.

Copy link

@LasseRafn LasseRafn commented Jan 16, 2020

Any progress on this? and/or any way I can help out? Really want to get 7.4 support out the door

@bsweeney

This comment has been minimized.

Copy link
Member

@bsweeney bsweeney commented Jan 16, 2020

Just about done. There's one more compatibility issue that was just identified around using the PDFLib adapter with PHP 7.2. I want to render various documents myself in 7.4 to see if I can identify anything else. Then I think we'll be ready.

I'll go ahead and get started with my render testing now in the background since I don't need to babysit that process.

@bsweeney

This comment has been minimized.

Copy link
Member

@bsweeney bsweeney commented Jan 20, 2020

OK, I think the code is pretty much ready. Should have it up this week.

@bsweeney

This comment has been minimized.

Copy link
Member

@bsweeney bsweeney commented Jan 20, 2020

and done

@bsweeney bsweeney closed this Jan 20, 2020
@bkuhl

This comment has been minimized.

Copy link
Author

@bkuhl bkuhl commented Jan 21, 2020

Woohoo! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.