Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP-font-lib as a git module #3

Closed
Marv51 opened this issue Nov 21, 2012 · 8 comments

Comments

Projects
None yet
4 participants
@Marv51
Copy link

commented Nov 21, 2012

This module worked before: https://github.com/acoulton/php-font-lib

I think this would be a good I idea.

Marvin

@amacneil

This comment has been minimized.

Copy link
Contributor

commented Nov 23, 2012

We had it as a submodule and removed it. If you're using composer it will be installed automatically. If you are using git to include DOMPDF then it's not a good idea to have submodules-inside-submodules anyway.

@bsweeney bsweeney closed this Nov 26, 2012

@bsweeney bsweeney reopened this Nov 26, 2012

@PhenX

This comment has been minimized.

Copy link
Member

commented Nov 26, 2012

@adrianmacneil, is there a problem if we put the submodule back ? Will it be in conflict with composer ?

@amacneil

This comment has been minimized.

Copy link
Contributor

commented Nov 26, 2012

I don't think there's any problem having it there for composer. It's just messy having a submodule in a package - phpfontlib should either just be included in the code (not a separate library), or a dependency, but not both.

@amacneil

This comment has been minimized.

Copy link
Contributor

commented Nov 26, 2012

My suggestion is to create a downloadable zip with phpfontlib included (of the latest stable version), and link to that from your README. People probably shouldn't be including the latest master branch in their projects anyway.

@PhenX

This comment has been minimized.

Copy link
Member

commented Nov 26, 2012

There are already zip packages available on Google Code: http://code.google.com/p/dompdf/downloads/list
I'll upload them on Github too.

@bsweeney

This comment has been minimized.

Copy link
Member

commented Nov 26, 2012

When I get a chance I'll updated the download on my site to use the git repo. When I do I'll also take into account any dependencies. Adding downloads to github will only be necessary when we have a new release. In that case we can have a version that includes all the necessary components.

That leaves people who download github's auto-archive. No doubt we'll get complaints about missing files, but hopefully they'll be few. We can pin a post on the support forum about this if necessary.

@PhenX

This comment has been minimized.

Copy link
Member

commented Nov 26, 2012

I finished to move the zips to Github, I also changed the links on Google Code to point to https://github.com/dompdf/dompdf/downloads

@amacneil

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2013

This was done long ago

@amacneil amacneil closed this Oct 9, 2013

artyfarty pushed a commit to artyfarty/dompdf that referenced this issue Jul 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.