Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support numeric font weights #675 #1896

Merged
merged 4 commits into from May 24, 2019

Conversation

@lquast
Copy link

lquast commented Feb 20, 2019

No description provided.

@honsa

This comment has been minimized.

Copy link

honsa commented Feb 20, 2019

Great, just a small step, but big thanks you for your great effort 💯

@bsweeney

This comment has been minimized.

Copy link
Member

bsweeney commented Feb 20, 2019

Thanks for the PR. This should give me enough motivation to do the work for 0.8.4.

@Sattevelt

This comment has been minimized.

Copy link

Sattevelt commented Mar 5, 2019

👍 Well done. I just wrote a lengthy comment to a related bugreport to help pinpoint where the problem is. And it instantly became redundant once i saw your PR 😄. I haven't tested the PR but, the logic in there seems ok and it nicely solves the problem of what numeric weights to concider as 'bold'.

src/Css/Style.php Outdated Show resolved Hide resolved
lquast added 2 commits May 23, 2019
@bsweeney bsweeney merged commit 17fb025 into dompdf:develop May 24, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.