Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google's material design icon set #35

Merged
merged 2 commits into from
Feb 8, 2017

Conversation

ebpa
Copy link
Contributor

@ebpa ebpa commented Feb 4, 2017

It would be nice to have the Material Design icons!

I've tested this addition on my system and works as expected.

The name mappings were created manually using iconfont/MaterialIcons-Regular.ijmap JSON data from https://github.com/google/material-design-icons.

Please preserve the underscore name delimiting. This naming style is used by the material design icon tools.

Note that at the font package version on Debian (1.4.57) has different unicode mappings that the current version that I have included (3.0.1). Icons may not render correctly if a user has an outdated version of the material design icons font. I haven't checked into when this mapping shifted.

@domtronn
Copy link
Owner

domtronn commented Feb 8, 2017

I've downloaded your branch, but I can't seem to get the Icons working properly...
Out of interest, what happens when you run (all-the-icons-insert-icons-for 'material) inside a fundamental-mode buffer?

Because it seems to me that the font that you've included doesn't seem to match up with the Unicode characters in data-material.el - For example, the 3d_rotation icon doesn't seem to exist in the font, however the Docs say it is, conversely, the font includes a bunch of different Battery icons (different charging states), but the Material Docs don't when you search for battery?

As you mentioned, you've noticed different unicode mappings for different versions which is why I've chosen to lock down the versions in this repo. So, if you don't mind, I'm going to try and find the font that does match up as you intended? 🙂

@domtronn
Copy link
Owner

domtronn commented Feb 8, 2017

Yep, I installed this version of the font instead and all my characters are working now! 👍

If you can update the font included in the PR with this one, and update the Font Family name to be Material Icons then I think this is good to go. Thanks!

The name mappings were created manually using
iconfont/MaterialIcons-Regular.ijmap JSON data from
https://github.com/google/material-design-icons.

Please preserve the underscore name delimiting.  This naming style is
used by the material design icon tools.

Note that at the font package version on Debian (1.4.57) has
different unicode mappings that the current version that I have
included (3.0.1).  Icons may not render correctly if a user has an
outdated version of the material design icons font.  I haven't checked
into when this mapping shifted.
@ebpa ebpa force-pushed the add-material-set branch from 2075360 to 27954e3 Compare February 8, 2017 04:57
@ebpa
Copy link
Contributor Author

ebpa commented Feb 8, 2017

Good catch. I copied the wrong one into the fonts directory. The version you point to is the same that I've been using on my system (md5 sum: a37b0c01c0baf1888ca812cc0508f6e2). I'm very sorry if that threw you for a loop. I revised the PR commit, so try a fresh pull please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants