Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register dynamic imports in the slim loader config #107

Merged
merged 1 commit into from Jan 5, 2018

Conversation

Projects
None yet
2 participants
@m-mujica
Copy link
Contributor

commented Jan 4, 2018

No description provided.

@matthewp
Copy link
Contributor

left a comment

No need to do the second getIntermediateAndImports call.

src/init.js Outdated
var localLoader = loader.localLoader || loader;
if (localLoader.slimConfig) {
var toMap = localLoader.slimConfig.toMap;
var res = getIntermediateAndImports(load.source);

This comment has been minimized.

Copy link
@matthewp

matthewp Jan 4, 2018

Contributor

This is already part of the result object, this is done by the ./parse module.

@m-mujica

This comment has been minimized.

Copy link
Contributor Author

commented Jan 4, 2018

@matthewp fixed.

@m-mujica m-mujica force-pushed the register-imports branch from 2d32eef to be32d76 Jan 5, 2018

@m-mujica m-mujica merged commit b2cfd63 into master Jan 5, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@m-mujica m-mujica deleted the register-imports branch Jan 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.